From: Michele <micxgx@gmail.com>
Date: Wed, 4 Mar 2015 00:51:19 +0000 (+0000)
Subject: appDisplay: Fix leaking signal connections
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~1586
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=99af774c9805a47973e40947246c2d9bdd29330f;p=gnome-shell.git

appDisplay: Fix leaking signal connections

The overview has a longer life-time than dash items, so we are leaking a
signal connection each time an item is destroyed.

https://bugzilla.gnome.org/show_bug.cgi?id=745570
---

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 9f505586e..1df417f0e 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1702,7 +1702,10 @@ const AppIcon = new Lang.Class({
                 if (!isPoppedUp)
                     this._onMenuPoppedDown();
             }));
-            Main.overview.connect('hiding', Lang.bind(this, function () { this._menu.close(); }));
+            let id = Main.overview.connect('hiding', Lang.bind(this, function () { this._menu.close(); }));
+            this.actor.connect('destroy', function() {
+                Main.overview.disconnect(id);
+            });
 
             this._menuManager.addMenu(this._menu);
         }